Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a test case to validate the handling of UNION and UNION ALL operators within view subqueries, addressing issue #104 in the pgschema repository.
Key changes:
- Added a new view
union_subquery_viewthat tests UNION and UNION ALL in subqueries - Updated test expectations to reflect 5 views instead of 4
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/diff/create_view/add_view/plan.txt | Updated plan output to include the new union_subquery_view in summary and DDL sections |
| testdata/diff/create_view/add_view/plan.sql | Added DDL for creating union_subquery_view with UNION and UNION ALL operators |
| testdata/diff/create_view/add_view/plan.json | Added JSON entry for the union_subquery_view creation operation |
| testdata/diff/create_view/add_view/new.sql | Added the source SQL definition for union_subquery_view with comprehensive comments |
| testdata/diff/create_view/add_view/diff.sql | Added the DDL diff showing the addition of union_subquery_view |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test case validate #104